Skip to content

feat(FR-833): Improve metric label formatting in user session history page#3500

Merged
graphite-app[bot] merged 1 commit into
mainfrom
feat/improve-metric-labeling
Apr 16, 2025
Merged

feat(FR-833): Improve metric label formatting in user session history page#3500
graphite-app[bot] merged 1 commit into
mainfrom
feat/improve-metric-labeling

Conversation

@ironAiken2
Copy link
Copy Markdown
Contributor

@ironAiken2 ironAiken2 commented Apr 15, 2025

resolves #3499 (FR-833)

Modify the mertric label formatting for proper notation.

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions Bot added the size:S 10~30 LoC label Apr 15, 2025
Copy link
Copy Markdown
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 4.18% 409/9790
🔴 Branches 3.54% 240/6772
🔴 Functions 2.54% 79/3112
🔴 Lines 4.11% 394/9575

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from f9fe4e4

@ironAiken2 ironAiken2 marked this pull request as ready for review April 15, 2025 02:25
@ironAiken2 ironAiken2 force-pushed the feat/improve-metric-labeling branch 2 times, most recently from 99a4b2b to 05307e8 Compare April 15, 2025 04:02
Comment thread react/src/pages/StatisticsPage.tsx Outdated
@ironAiken2 ironAiken2 force-pushed the feat/improve-metric-labeling branch from 05307e8 to 1c5590a Compare April 16, 2025 01:56
@ironAiken2 ironAiken2 requested a review from agatha197 April 16, 2025 01:57
Copy link
Copy Markdown
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby dismissed agatha197’s stale review April 16, 2025 06:45

It' already resolved

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 16, 2025

Merge activity

… page (#3500)

resolves #3499 (FR-833)
<!-- replace NNN, MMM with the GitHub issue number and the corresponding Jira issue number. -->

### Modify the mertric label formatting for proper notation.

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@graphite-app graphite-app Bot force-pushed the feat/improve-metric-labeling branch from 1c5590a to f9fe4e4 Compare April 16, 2025 06:46
@graphite-app graphite-app Bot merged commit f9fe4e4 into main Apr 16, 2025
6 checks passed
@graphite-app graphite-app Bot deleted the feat/improve-metric-labeling branch April 16, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10~30 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve metric label formatting with human-readable names in user session history page

3 participants